Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the meta click area fit to its visible area #62774

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jul 6, 2022

Fix #53599.

Previously, items of type ITEM_NEWLINE were ignored, these items had information about their parent item, which might be useful in some cases.

Before After
1 2

@Rindbee Rindbee requested a review from a team as a code owner July 6, 2022 12:40
@bruvzg bruvzg self-requested a review July 6, 2022 12:41
scene/gui/rich_text_label.cpp Outdated Show resolved Hide resolved
@KoBeWi KoBeWi added this to the 4.0 milestone Jul 6, 2022
@Rindbee Rindbee force-pushed the make-the-meta-click-area-fit branch from 8c574b2 to 5267ad7 Compare July 7, 2022 13:16
@Rindbee
Copy link
Contributor Author

Rindbee commented Jul 7, 2022

Click vacuums are now eliminated, these are mostly indents created by indent/ul/ol tags.

Such as the following example. Different colored boxes are used to indicate different types of invisible areas.

  1. Blue is for ITEM_NEWLINE.
  2. Red is for ITEM_INDENT.
  3. Yellow is for ITEM_LIST.
  4. Green is for margin.
test text
[p dir=rtl]begin[/p]
rdy
test[color=red]red[/color]
sfsdf
[indent]test
test[url]sdfsdf[/url]
tesst
[ol]
t[url]est[/url]
sfg
gs
test
[ol]
tests[color=red]red[/color]
[indent]tasest
[indent]testfd
test
[ol]test[color=green]green[/color]test[/ol]test
[/indent][/indent]s
[/ol]
[/ol]
[/indent]
test
LTR RTL
1 2

I haven't figured out what they are used for yet, maybe they can be used for quick selection/de-selection. However, the red, yellow and blue click area will not be a vacuum. You can click on these areas for related information.

Eliminate the click vacuum area, mainly the indentation generated by indent/ul/ol tags
@Rindbee Rindbee force-pushed the make-the-meta-click-area-fit branch from 5267ad7 to 74f99f7 Compare July 12, 2022 23:14
@akien-mga akien-mga merged commit c17af2c into godotengine:master Jul 13, 2022
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the make-the-meta-click-area-fit branch July 13, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in editor help have bigger clickable area than they should
4 participants