Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local variables not showing in debugger when break-pointing on final line #58201

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix local variables not showing in debugger when break-pointing on final line #58201

merged 1 commit into from
Mar 4, 2022

Conversation

SaracenOne
Copy link
Member

Changes the scoping check in debug_get_stack_member_state line from > to >=, which should prevent relevant local variables being excluded from the debug message when debugging from the final line of a scoped code block.

Close #58200

@SaracenOne SaracenOne requested a review from a team as a code owner February 16, 2022 18:23
@SaracenOne SaracenOne changed the title Fix local variables not showing when breaking on final line Fix local variables not showing in debugger when break-pointing on final line Feb 16, 2022
@akien-mga akien-mga added this to the 4.0 milestone Feb 16, 2022
vnen
vnen approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never dug deeply in the debugger code TBH, but since it's solving the issue it should be fine.

@akien-mga akien-mga merged commit e133ade into godotengine:master Mar 4, 2022
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the debugger_locals branch September 16, 2022 21:00
@Banderi Banderi mentioned this pull request Jan 8, 2023
Closed
@Banderi Banderi mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

GDScript debugger does not show scoped local variables when breakpointing final line
3 participants
@SaracenOne @akien-mga @vnen