[3.x] Add focus font color to Button and derivatives
#54264
Conversation
| @@ -380,6 +380,7 @@ Ref<Theme> create_editor_theme(const Ref<Theme> p_theme) { | |||
|
|
|||
| const Color font_color = mono_color.linear_interpolate(base_color, 0.25); | |||
| const Color font_color_hl = mono_color.linear_interpolate(base_color, 0.15); | |||
| const Color font_color_focus = mono_color.linear_interpolate(base_color, 0.15); | |||
There was a problem hiding this comment.
If it's the same as font_color_hl, why couldn't you just reuse it?
There was a problem hiding this comment.
It's the same for the purpose of quickly fixing it, but I fully expect we may want to tune it (granted, probably not in 3.4). I just think that it will be easier to customize if needs be.
The difference would be like one line, this line.
|
D'oh, forgot the docs. One moment! Edit: Done. |
YuriSizov
force-pushed
the
controls-button-font-focus-3.x
branch
from
85f3ad7
to
c4fb4c1
Compare
YuriSizov
force-pushed
the
controls-button-font-focus-3.x
branch
from
c4fb4c1
to
aff8d2f
Compare
| if (has_color("icon_color_focus")) { | ||
| color_icon = get_color("icon_color_focus"); | ||
| } |
There was a problem hiding this comment.
This color isn't defined anywhere.
There was a problem hiding this comment.
Yes, all icon_color_* options are like that, I've mentioned it on RC. I've added it for consistency, but I decided not to add definitions for any of them in this PR. They are used for some strange part of ToolButton (along with the icon icon, similarly unexposed). In master they seem to be properly exposed for the Button type.
YuriSizov
force-pushed
the
controls-button-font-focus-3.x
branch
from
aff8d2f
to
7fe0dab
Compare
|
Thanks! |
Fixes #52620 by adding a new color theme property. By default it mimics the hover style, because that's what it used to behave like before #47280.
Focus only overrides the normal style. Pressed, hover, and disabled take precedence over the color if they are applicable.
2021-10-26_16-34-57.mp4
masterversioncoming soon.: #54267