Re-add a Camera3D icon gizmo to the 3D editor, renew Camera2D/3D icons #53104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, what is it missing? |
As I wrote in OP:
I've started working on those icons a while ago, I'll try to finish them ASAP. |
Calinou
force-pushed
the
editor-readd-camera-gizmo-icon
branch
from
286f451
to
3364211
Compare
Calinou
changed the title
|
I pushed new icons for Camera2D and Camera3D:
Let me know if this is OK. |
|
It's been in draft for 2 years, maybe we can merge what's made already? Or poke MewPurPur if you need help ;) |
The lack of icon gizmo made it no longer possible to select Camera3D nodes in the 3D viewport by clicking on them. A new Camera3D icon gizmo was designed to be direction-neutral. This avoids the issue that the previous icon gizmo had, since it was always facing right. This also adds icons for CameraAttributesPractical and CameraAttributesPhysical.
Calinou
force-pushed
the
editor-readd-camera-gizmo-icon
branch
from
3364211
to
e21388d
Compare
I've finished all icons; it's ready for review now. |
akien-mga
approved these changes
Aug 8, 2023
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as draft, as new Camera2D and Camera3D node icons should be created to match the new icon gizmo design.
The lack of icon gizmo made it no longer possible to select Camera3D nodes in the 3D viewport by clicking on them.
A new Camera3D icon gizmo was designed to be direction-neutral. This avoids the issue that the previous icon gizmo had, since it was always facing right.
This closes #53083.
Preview
Listener3D on the left, Camera3D in the middle, ReflectionProbe on the right.