Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabContainer Fix moving dropped tab to incorrect child index #51177

Merged

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Aug 2, 2021

When tab was dropped its index among TabContainer's children was calculated without taking into account non-tab children of the TabContainer, bug in action:
6S6OH2u9SH

Cherry-pickable.

@kleonc kleonc requested a review from a team as a code owner August 2, 2021 12:26
@KoBeWi KoBeWi added this to the 4.0 milestone Aug 2, 2021
@KoBeWi KoBeWi added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 2, 2021
@akien-mga akien-mga merged commit e0b560f into godotengine:master Aug 3, 2021
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the tab_container-drop-tab-index-fix branch August 3, 2021 07:53
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 3, 2021
@kleonc
Copy link
Member Author

kleonc commented Aug 3, 2021

@akien-mga Cherry-pick for 3.3?

@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants