Fix crash when using ALSA MIDI with PulseAudio #48350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess it might be relevant yes, this code didn't change much in |
RandomShaper
force-pushed
the
fix_alsamidi_crash
branch
from
2d3a498
to
958d798
Compare
RandomShaper
changed the title
RandomShaper
added
the
cherrypick:3.x
|
I've rebased the commit against master and retargeted the PR. It seems the code is indeed so similar that cherry-picking is trivial. (Sorry for the mess just after the re-push. Everything should be tidy again.) |
akien-mga
approved these changes
Jun 3, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is due to symbols from ALSA library being null if the main audio driver is PulseAudio.
Since @hpvb worked on dynamic library loading and is more Linux-savvy than me, I'm asking him for review.
I'm not sure if this patch needs a version for 4.0.
Fixes #46183.