Added driving joystick type to windows joystick handling #44082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #31200 |
|
A PR for |
|
I'll add it in, its just that I am still working mostly in 3.2 :) |
BastiaanOlij
force-pushed
the
add_driving_joytype
branch
from
1312c8c
to
dad2bbc
Compare
BastiaanOlij
force-pushed
the
add_driving_joytype
branch
from
dad2bbc
to
cf5737a
Compare
BastiaanOlij
added
the
cherrypick:3.x
|
@akien-mga now on master. I had to hack the joystick demo a bit to test it but it works pretty good |
akien-mga
approved these changes
Dec 4, 2020
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing around with my new G29 steeringwheel, found out that Godot stopped recognising it as a joystick after installing drivers. Turns out that when proper drivers are installed, steering wheel is recognised in Windows as DI8DEVTYPE_DRIVING
and we're ignoring that one.
So simply added that to the list of things we no longer ignore and it works like a charm.
If cherry picked for 3.2 our 16 button limit is not enough for our G29 shifter buttons but we have 36 buttons in Godot 4 so :).