Improve OS::get_locale() and documentation.
#40708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2020
|
Does this PR supersede #37246? |
bruvzg
force-pushed
the
improve_os_locale
branch
from
6a3f81c
to
ca8e012
Compare
bruvzg
force-pushed
the
improve_os_locale
branch
from
ca8e012
to
3a9400e
Compare
… and use system macros instead of bitwise AND. Add locale format info to the documentation.
bruvzg
force-pushed
the
improve_os_locale
branch
from
3a9400e
to
f797e1c
Compare
akien-mga
reviewed
Dec 10, 2020
Comment on lines
+206
to
+209
| [code]Script[/code] - optional, 4 letter [url=https://en.wikipedia.org/wiki/ISO_15924]script code[/url], in title case. | ||
| [code]COUNTRY[/code] - optional, 2 or 3 letter [url=https://en.wikipedia.org/wiki/ISO_3166-1]country code[/url], in upper case. | ||
| [code]VARIANT[/code] - optional, language variant, region and sort order. Variant can have any number of underscored key words. | ||
| [code]extra[/code] - optional, semicolon separated list of additional key words. Currency, calendar, sort order and numbering system information. |
There was a problem hiding this comment.
I'm guessing some of those are OS-specific, maybe this should be documented too? Or do all OSes follow the same format aside from some using - and others using _?
There was a problem hiding this comment.
The overall pattern is valid for all OSes, but none of the locales have all parts. Only @ is Linux specific, the rest can be encountered on any OS.
akien-mga
approved these changes
Dec 10, 2020
|
Thanks! |
|
Ah I merged without waiting for feedback on my above comment, I thought I was looking at another PR :P |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS and Windows, replace
-with_.On Windows use system macros instead of bitwise AND.
Add locale format info to the documentation.
Related issue #40703
Fixes #37203