[EditorInspector] Fix ImportDock and ProjectExport capitalize #21234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
editor/import_dock.cpp
Outdated
| @@ -423,6 +423,7 @@ ImportDock::ImportDock() { | |||
| import_opts = memnew(EditorInspector); | |||
| add_child(import_opts); | |||
| import_opts->set_v_size_flags(SIZE_EXPAND_FILL); | |||
| import_opts->set_enable_capitalize_paths(bool(EDITOR_GET("interface/inspector/capitalize_properties"))); | |||
There was a problem hiding this comment.
CC @akien-mga Maybe we should rename this path interface/inspector/capitalize_properties to a more generic.
There was a problem hiding this comment.
Or should I use a different names for this? or maybe this can be the default to true instead of use EDITOR_GET?
There was a problem hiding this comment.
I think it should default to true in EditorInspector.
There was a problem hiding this comment.
Changed.
guilhermefelipecgs
force-pushed
the
fix_inspector_capitalize
branch
from
791a839
to
da40211
Compare
guilhermefelipecgs
force-pushed
the
fix_inspector_capitalize
branch
from
da40211
to
50326a0
Compare
| @@ -1536,7 +1536,7 @@ void EditorInspector::update_tree() { | |||
|
|
|||
| Color c = sscolor; | |||
| c.a /= level; | |||
| section->setup(path_name, path_name, object, c, use_folding); | |||
| section->setup(acc_path, path_name, object, c, use_folding); | |||
There was a problem hiding this comment.
For reference, I inverted path_name with acc_name to fix section names:
without change:
whit this change:
guilhermefelipecgs
changed the title
This was referenced Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21216 (comment)