Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: apache guacamole: cleanup doc page #10354

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Jul 3, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: 4d62 <ext@4d62.me>
@4d62 4d62 requested a review from a team as a code owner July 3, 2024 21:34
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 5087ef7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/668684cfefe927000824f4e7
😎 Deploy Preview https://deploy-preview-10354--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 5087ef7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/668684cf1f46010008dbb096
😎 Deploy Preview https://deploy-preview-10354--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (2fc0c6e) to head (5087ef7).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10354   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         713      713           
  Lines       34999    34999           
=======================================
  Hits        32418    32418           
  Misses       2581     2581           
Flag Coverage Δ
e2e 49.56% <ø> (ø)
integration 25.38% <ø> (ø)
unit 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4d62
Copy link
Contributor Author

4d62 commented Jul 3, 2024

cc @tanberry. part of my larger pr. dividing it in smaller parts

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! Yep, "loose" versus "lose" is a doozy; I'm glad you caught that. And capitalizing Docker. Appreciate your help.

@4d62
Copy link
Contributor Author

4d62 commented Jul 3, 2024

np 😉

@tanberry
Copy link
Contributor

tanberry commented Jul 3, 2024

Hmmmm the lint (prettier-check) build check is failing. Can you try running make website again and pushing to PR? If that doesn't fix it I'll ask on of the engineers to look at it. (We can safely ignore the other fails.)

@4d62
Copy link
Contributor Author

4d62 commented Jul 3, 2024

@tanberry fixed. I seem to always forget to lint

@4d62
Copy link
Contributor Author

4d62 commented Jul 3, 2024

image

@tanberry
Copy link
Contributor

tanberry commented Jul 3, 2024

I think it might be something on our side... let me talk to eng about it tomorrow.

@rissson rissson changed the title docs/integrations: apache guacamole: cleanup doc page website/integrations: apache guacamole: cleanup doc page Jul 4, 2024
@BeryJu BeryJu merged commit fbad6fb into goauthentik:main Jul 4, 2024
60 of 66 checks passed
@4d62 4d62 deleted the patch-1 branch July 4, 2024 12:18
kensternberg-authentik added a commit that referenced this pull request Jul 5, 2024
* main: (350 commits)
  web: bump @swc/core from 1.6.6 to 1.6.7 in /web/sfe (#10395)
  web: bump @sentry/browser from 8.14.0 to 8.15.0 in /web in the sentry group across 1 directory (#10388)
  website/integrations: aws: cleanup (#10355)
  web: bump API Client version (#10389)
  web/flows: Simplified flow executor (#10296)
  website/docs: sources: ldap: remove extra example (#10387)
  website/docs: add new content from old PR #9524 (#10158)
  stages/authenticator_validate: fix friendly_name being required (#10382)
  core: bump go api client (#10383)
  web: bump API Client version (#10381)
  outposts: make refresh interval configurable (#10138)
  core, web: update translations (#10378)
  web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379)
  core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380)
  sources/oauth: fix link not being saved (#10374)
  website/docs: update postgres on docker: fix backtick (#10372)
  website/integrations: apache guacamole: cleanup doc page (#10354)
  web: bump API Client version (#10371)
  Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370)
  web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362)
  ...
kensternberg-authentik added a commit that referenced this pull request Jul 10, 2024
* main: (29 commits)
  website/integrations: aws: cleanup (#10355)
  web: bump API Client version (#10389)
  web/flows: Simplified flow executor (#10296)
  website/docs: sources: ldap: remove extra example (#10387)
  website/docs: add new content from old PR #9524 (#10158)
  stages/authenticator_validate: fix friendly_name being required (#10382)
  core: bump go api client (#10383)
  web: bump API Client version (#10381)
  outposts: make refresh interval configurable (#10138)
  core, web: update translations (#10378)
  web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379)
  core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380)
  sources/oauth: fix link not being saved (#10374)
  website/docs: update postgres on docker: fix backtick (#10372)
  website/integrations: apache guacamole: cleanup doc page (#10354)
  web: bump API Client version (#10371)
  Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370)
  web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362)
  core: bump goauthentik.io/api/v3 from 3.2024060.2 to 3.2024060.3 (#10356)
  website: bump react-tooltip from 5.27.0 to 5.27.1 in /website (#10357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants