Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove context sync.Pool to avoid data races. #3072

Merged
merged 9 commits into from
Nov 7, 2023

Conversation

lyouthzzz
Copy link
Contributor

Description (what this PR does / why we need it):

This PR will fix data race issues caused by object reuse with sync.Pool.

Which issue(s) this PR fixes (resolves / be part of):

more detail for bug issue: #3070

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #3072 (6d36bc8) into main (3fc8fb7) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 6d36bc8 differs from pull request most recent head 52aecce. Consider uploading reports for the commit 52aecce to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
- Coverage   84.46%   84.35%   -0.12%     
==========================================
  Files          88       88              
  Lines        3992     3988       -4     
==========================================
- Hits         3372     3364       -8     
- Misses        446      448       +2     
- Partials      174      176       +2     
Files Coverage Δ
transport/http/router.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@tonybase tonybase merged commit 7d2c8ea into go-kratos:main Nov 7, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants