Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global/Eclipse] add ".project" file #2969

Closed
wants to merge 1 commit into from
Closed

[Global/Eclipse] add ".project" file #2969

wants to merge 1 commit into from

Conversation

jskelin
Copy link

@jskelin jskelin commented Feb 21, 2019

ignore project description file

Reasons for making this change:

Ignore generated file by eclipse .

Links to documentation supporting these rule changes:

https://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fproject_description_file.html

If this is a new template:

  • Link to application or project’s homepage: TODO

ignore project description file
@shiftkey shiftkey changed the title add ".project" file [Global/Eclipse] add ".project" file Mar 8, 2019
@shiftkey
Copy link
Member

@jskelin actually, this comment from the link makes me curious:

The purpose of this file is to make the project self-describing, so that a project that is zipped up or released to a server can be correctly recreated in another workspace.

This to me feels like it has value, and might be useful to have in version control, even if it's generated. Can you elaborate on why it's safe to exclude this from version control?

@larry1186
Copy link
Contributor

Looks like @jskelin does not have this project forked anymore. I think it would still be beneficial to at least address the .project file in the template. I have opened my own Pull Request #3305 to make it opt-in to ignore. Could this possibly be extended to .cproject already ignored or perhaps .classpath/.settings?

A few other templates have the .project file listed, but should be consolidated to the Eclipse .gitignore.

@shiftkey
Copy link
Member

shiftkey commented Feb 9, 2020

@larry1186 thanks for submitting #3305 - I'm going to close this out as it's now unnecessary

@shiftkey shiftkey closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants