Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update set cookie example #2312

Merged
merged 1 commit into from
Apr 8, 2020
Merged

update set cookie example #2312

merged 1 commit into from
Apr 8, 2020

Conversation

linvis
Copy link
Contributor

@linvis linvis commented Apr 5, 2020

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integrations systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@linvis
Copy link
Contributor Author

linvis commented Apr 5, 2020

samesite had been removed from method setCookie, see this PR, so update this example in README.md

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #2312 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2312   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          41       41           
  Lines        2304     2304           
=======================================
  Hits         2267     2267           
  Misses         21       21           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3315353...65ac335. Read the comment docs.

@linvis linvis mentioned this pull request Apr 8, 2020
@appleboy appleboy added this to the 1.7 milestone Apr 8, 2020
@appleboy appleboy merged commit 4f20888 into gin-gonic:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants