Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(badge): add todo badge #2240

Merged
merged 2 commits into from
Feb 21, 2020
Merged

docs(badge): add todo badge #2240

merged 2 commits into from
Feb 21, 2020

Conversation

appleboy
Copy link
Member

fix #2236

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integrations systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #2240 into master will not change coverage.
The diff coverage is 96.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          41       41           
  Lines        2288     2288           
=======================================
  Hits         2251     2251           
  Misses         21       21           
  Partials       16       16
Impacted Files Coverage Δ
render/msgpack.go 100% <ø> (ø) ⬆️
binding/msgpack.go 100% <ø> (ø) ⬆️
binding/binding.go 100% <ø> (ø) ⬆️
render/render.go 100% <ø> (ø) ⬆️
path.go 100% <100%> (ø) ⬆️
auth.go 100% <100%> (ø) ⬆️
gin.go 98.29% <100%> (ø) ⬆️
binding/form_mapping.go 100% <100%> (ø) ⬆️
binding/binding_nomsgpack.go 100% <100%> (ø) ⬆️
render/json.go 87.5% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41469bf...950435a. Read the comment docs.

@thinkerou thinkerou self-requested a review February 21, 2020 08:33
@thinkerou thinkerou added this to the 1.6 milestone Feb 21, 2020
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou merged commit 863ad2d into gin-gonic:master Feb 21, 2020
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
fix gin-gonic#2236

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TODOs Badge to README
2 participants