Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not use protobuf on context but use it on render #1496

Merged
merged 1 commit into from
Aug 19, 2018
Merged

not use protobuf on context but use it on render #1496

merged 1 commit into from
Aug 19, 2018

Conversation

thinkerou
Copy link
Member

ref #1479
please @salamer @appleboy help review, thanks!

@codecov
Copy link

codecov bot commented Aug 19, 2018

Codecov Report

Merging #1496 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          37       37           
  Lines        1905     1905           
=======================================
  Hits         1889     1889           
  Misses         13       13           
  Partials        3        3
Impacted Files Coverage Δ
render/json.go 100% <ø> (ø) ⬆️
render/render.go 100% <ø> (ø) ⬆️
context.go 99.49% <100%> (ø) ⬆️
render/protobuf.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdd3c8...2b3ee95. Read the comment docs.

@appleboy appleboy added this to the 1.4 milestone Aug 19, 2018
@thinkerou thinkerou merged commit 6073a79 into gin-gonic:master Aug 19, 2018
@thinkerou thinkerou deleted the pb branch August 19, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants