Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binding): Add support for struct level validations #1147

Conversation

sudo-suhas
Copy link
Contributor

validator allows for struct level validation - https://github.com/go-playground/validator/releases/tag/v8.7. This adds a method, RegisterStructValidation, to the StructValidator interface and implements the same in defaultValidator. A test for the same has also present. I added an example but did not included the entire example in README.md. Not everybody would need this feature and the readme is already a bit large.

@sudo-suhas sudo-suhas force-pushed the feat/register-struct-validation branch 2 times, most recently from 29ca5d9 to 7d5af53 Compare October 27, 2017 10:23
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #1147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1147   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          16       16           
  Lines        1721     1721           
=======================================
  Hits         1664     1664           
  Misses         49       49           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e88466...99656ba. Read the comment docs.

@sudo-suhas sudo-suhas force-pushed the feat/register-struct-validation branch from 7d5af53 to a83eb4c Compare October 27, 2017 10:27
@sudo-suhas sudo-suhas force-pushed the feat/register-struct-validation branch from a83eb4c to 99656ba Compare October 27, 2017 10:36
@appleboy appleboy added this to the 1.3 milestone Nov 12, 2017
@sudo-suhas sudo-suhas deleted the feat/register-struct-validation branch March 29, 2018 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants