feat(routes): Catch-All form should not include the slash before param

[easonlin404]

Fix #279. Base on 42e0c82 work.

[codecov]

Codecov Report

Merging #1061 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   96.65%   96.66%   +<.01%     
==========================================
  Files          16       16              
  Lines        1706     1707       +1     
==========================================
+ Hits         1649     1650       +1     
  Misses         49       49              
  Partials        8        8

Impacted Files	Coverage Δ
tree.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211c48f...cb7fde2. Read the comment docs.

[tboerger]

This will potentially break installations that already rely on this behavior

[javierprovecho]

I agree with @tboerger , I've faced this sometimes. However I always stripped the / using https://golang.org/pkg/strings/#TrimPrefix which is much more secure. Using path[1:] carries much more risk, because it trims whatever is the first char.

I'm not sure, yet.

EDIT: a notice on version changelog in bold BREAKING would help? it's a one line fix for broken behavior

[easonlin404]

Maybe add path[1:] condition to determine if the first char is / to reduce usage risk ?

For breakdown api, add BREAKING doc LGTM and can wait #1084 discussing to get future steps. 😄

[ashtonian]

what needs to be done to merge this, is it just the tests or is there another reason?

This breaks the binding functionality for optional parameters.

[ashtonian]

since its been 2 years since this PR was submitted, would you be open to change it to be a configurable option based on a variable somewhere? If so where would I add that variable ? maybe get it via env once on init or something?

TRIM_WILDCARD_SLASH := false // TODO: move me and make me configurable 
...
		} else if TRIM_WILDCARD_SLASH && path[1:1] == "/" {
						value.params[i].Value = path[1:]
                }
...

[percona-csalguero]

Any news on this issue?

[thinkerou]

@appleboy we need to merge the PR to v1.6?

[appleboy]

Move to v1.7 milestone?