Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make : do not add linker flags when compiling static llava lib #3977

Merged
merged 1 commit into from
Nov 7, 2023
Merged

make : do not add linker flags when compiling static llava lib #3977

merged 1 commit into from
Nov 7, 2023

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Nov 7, 2023 •
edited
Loading

Fixes build warnings on macOS:

c++ -I. -Icommon -D_XOPEN_SOURCE=600 -D_DARWIN_C_SOURCE -DNDEBUG -DGGML_USE_ACCELERATE -DACCELERATE_NEW_LAPACK -DACCELERATE_LAPACK_ILP64 -DGGML_USE_METAL  -std=c++11 -fPIC -O3 -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function -Wmissing-declarations -Wmissing-noreturn -pthread  -Wunreachable-code-break -Wunreachable-code-return -Wmissing-prototypes -Wextra-semi  -static -fPIC -c examples/llava/llava.cpp -o libllava.a -framework Accelerate -framework Foundation -framework Metal -framework MetalKit  -Wno-cast-qual
clang: warning: -framework Accelerate: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework Foundation: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework Metal: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework MetalKit: 'linker' input unused [-Wunused-command-line-argument]

@monatis monatis merged commit 413503d into master Nov 7, 2023
59 checks passed
@monatis monatis deleted the fix-libllava-ld branch November 7, 2023 17:27
olexiyb pushed a commit to Sanctum-AI/llama.cpp that referenced this pull request Nov 23, 2023
@ggerganov @olexiyb
make : do not add linker flags when compiling static llava lib (ggerg…
4f9bc74 
…anov#3977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

@monatis monatis monatis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggerganov @cebtenzzre @monatis