Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip shlex for win32 platforms #3651

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Skip shlex for win32 platforms #3651

merged 3 commits into from
Dec 10, 2022

Conversation

JesperDramsch
Copy link
Contributor

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Changed GzipFile() to create deterministic compression with mtime=0 argument. (Issue #3650)

Fixed custom command parsing on windows due to shlex non-interoperability. (Issue #3649)

@JesperDramsch JesperDramsch marked this pull request as ready for review December 10, 2022 16:17
This was linked to issues Dec 10, 2022
Shlex does not parse Windows paths correctly #3649
Closed
Make GZIP deterministic #3650
Closed
@JesperDramsch
Copy link
Contributor Author

Thanks for the quick response!

Have a great weekend.

@Kwpolska Kwpolska merged commit 9df43da into getnikola:master Dec 10, 2022
@Kwpolska
Copy link
Member

Thanks for contributing this, and have a great weekend too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make GZIP deterministic Shlex does not parse Windows paths correctly
2 participants
@JesperDramsch @Kwpolska