Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detection and driver for parameter GUI. #5735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jun 2, 2024

closes #5706

@gassmoeller
Copy link
Member

I would prefer if you could rename this PR. What you are doing is removing the automatic configuration of the ASPECT-GUI as part of the ASPECT build process. It is still possible to compile ASPECT-GUI separately and call it with ASPECT input file. I just want to avoid the perception that ASPECT-GUI is deleted.

@gassmoeller
Copy link
Member

We agreed to keep this open for a bit until we see how #5697 develops.

@tjhei
Copy link
Member Author

tjhei commented Jun 2, 2024

What you are doing is removing the automatic configuration of the ASPECT-GUI as part of the ASPECT build process. It is still possible to compile ASPECT-GUI separately and call it with ASPECT input file.

Not really, I am also deleting ./doc/aspect-gui, the magic bash script that makes the GUI work.

@bangerth
Copy link
Contributor

bangerth commented Jun 2, 2024

I'll rename to make this clearer. OK to merge from my side.

@bangerth bangerth changed the title remove parameter GUI Remove detection and drive for parameter GUI. Jun 2, 2024
@bangerth
Copy link
Contributor

bangerth commented Jun 2, 2024

This might be worth a changelog entry.

@tjhei
Copy link
Member Author

tjhei commented Jun 2, 2024

changelog entry added. Since we are deleting the bash script that provides the deal.II parameter GUI with the parameter information, I would still think that this PR removes the GUI. I don't know how someone would use it after this PR is merged.

@gassmoeller
Copy link
Member

You are right, I misinterpreted the PR when I wrote my first comment. Technically the deal.II program is still there, but it requires some special knowledge to run it after this PR is merged.

@bangerth bangerth changed the title Remove detection and drive for parameter GUI. Remove detection and driver for parameter GUI. Jun 3, 2024
@bangerth
Copy link
Contributor

bangerth commented Jun 3, 2024

@tjhei Out of curiosity, why is it that you want to get rid of this? I don't really care one way or other, but it's a relatively small amount of code, and could at least in principle be useful to some.

@tjhei
Copy link
Member Author

tjhei commented Jun 7, 2024

Because none of us uses it, so I assume it will stop working correctly (maybe it has already). We advertise it in the manual even though we know better ways to edit .prm files and that could lead people down a wrong path.
I think it is the same situation as the PETSc support, which was a good idea to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove parameter-gui?
3 participants