-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove detection and driver for parameter GUI. #5735
base: main
Are you sure you want to change the base?
Conversation
I would prefer if you could rename this PR. What you are doing is removing the automatic configuration of the ASPECT-GUI as part of the ASPECT build process. It is still possible to compile ASPECT-GUI separately and call it with ASPECT input file. I just want to avoid the perception that ASPECT-GUI is deleted. |
We agreed to keep this open for a bit until we see how #5697 develops. |
Not really, I am also deleting ./doc/aspect-gui, the magic bash script that makes the GUI work. |
I'll rename to make this clearer. OK to merge from my side. |
This might be worth a changelog entry. |
changelog entry added. Since we are deleting the bash script that provides the deal.II parameter GUI with the parameter information, I would still think that this PR removes the GUI. I don't know how someone would use it after this PR is merged. |
You are right, I misinterpreted the PR when I wrote my first comment. Technically the deal.II program is still there, but it requires some special knowledge to run it after this PR is merged. |
@tjhei Out of curiosity, why is it that you want to get rid of this? I don't really care one way or other, but it's a relatively small amount of code, and could at least in principle be useful to some. |
Because none of us uses it, so I assume it will stop working correctly (maybe it has already). We advertise it in the manual even though we know better ways to edit .prm files and that could lead people down a wrong path. |
closes #5706