-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for spherical system #5629
base: main
Are you sure you want to change the base?
Conversation
Assert (coordinate_system == Utilities::Coordinates::CoordinateSystem::cartesian, | ||
ExcNotImplemented()); | ||
ExcMessage("While using a box geometry, use cartesian coordinate system.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to say
ExcMessage("While using a box geometry, use cartesian coordinate system.")); | |
ExcMessage("While using a box geometry, you can only use the cartesian coordinate system.")); |
?
Assert (coordinate_system == Utilities::Coordinates::CoordinateSystem::spherical, | ||
ExcMessage("Make sure that you are using a spherical coordinate system While using a spherical geometry.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert (coordinate_system == Utilities::Coordinates::CoordinateSystem::spherical, | |
ExcMessage("Make sure that you are using a spherical coordinate system While using a spherical geometry.")); | |
Assert (coordinate_system == Utilities::Coordinates::CoordinateSystem::spherical, | |
ExcMessage("Make sure that you are using a spherical coordinate system while using a spherical geometry.")); |
Assert (coordinate_system == Utilities::Coordinates::CoordinateSystem::spherical, | ||
ExcMessage("Make sure that you are using a spherical coordinate system While using a spherical geometry.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the assertion to the top of the code block. Everything in this block is wrong if the assertion is not satisfied, we might as well abort there.
@alarshi: This is actually not quite the implementation I had in mind in #5626. I was thinking we should allow users to choose which coordinate system to use (as in boundary_temperature/function.cc), not force them to use the coordinate system corresponding to their chosen geometry model. It is possible that that is not the right approach for initial_topography, but can you think about it and let me know what you think is most useful? |
@gassmoeller : I see. I can think of cases where a user might want to use the initial topography from another model run (fastscape?) as an input to ASPECT models. I agree that having a choice between cartesian/spherical would be useful. |
@gassmoeller : Hmm, I see why the function in |
This PR addresses one of the bullet points in issue #5626. In particular, it allows the user to use
spherical
coordinate system while usinginitial_topography function
model.Before your first pull request:
For all pull requests: