-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a debug mode to simplify quick bug analysis #840
Comments
@roll just to add additional motivation for this I've had a hard time tracking down a wrong delimiter ( Here is an example of the message: from frictionless import Package, validate_resource
from pprint import pprint
dp = Package('https://raw.githubusercontent.com/dados-mg/datapackage-reprex/bad-dialect-delimiter/datapackage.json')
report = validate_resource(dp.get_resource('pib-per-capita'))
pprint(report)
I think that this more obscure message has something to do with the fact that the resource Ps. I've found #903 in the process of investigating this problem and initially though they could be related. 😅 |
Essa mensagem de erro pouco informativa acontece quando o separador dos dados no arquivo csv não está de acordo com o especificado no dialect.json Vide frictionlessdata/frictionless-py#840 para histórico
@roll What do you think a useful debug mode would be, just add some logging.debug where we currently have exceptions or are you thinking in something else? |
For a starter, $ frictionless validate table.csv --debug that won't be swallowing exceptions as a part of validation report. In general, it's about internal error reporting -- we don't need any interactive debugging etc ATM |
Ok, if we don't swallow the exception, what we are going to do with it? I did some tests raising the exception on the CLI when a validation report was being created, but I don't see which additional information to add. Show the exception and which line it happened? |
I think just letting the app fail with the exception would be a good start. Another question - how to keep debug/not-debug state. I think we need to create a |
Hi @aivuk, Let's park this issue for now (moving to Blocked) as I'm reworking exception for v5 so we might not need to the way we discussed |
DONE in #1119 |
Overview
We need a debug mode available because errors are caught in a few places in the framework. For example, the CLI catches all the errors or
Report.from_validate
.We might use an env var or a flag
The text was updated successfully, but these errors were encountered: