Skip to content

Commit

Permalink
Add support for migrated jslib (bitwarden#2826)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hinton committed Jun 3, 2022
1 parent 71e076b commit 5780bf8
Show file tree
Hide file tree
Showing 58 changed files with 128 additions and 43,182 deletions.
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ root = true
[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

# Set default charset
[*.{js,ts,scss,html}]
Expand Down
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
**/build
**/dist
**/jslib

**/node_modules

Expand Down
5 changes: 5 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@
56477eb39cfd8a73c9920577d24d75fed36e2cf5
# Web: Monorepository https://github.com/bitwarden/clients/commit/02fe7159034b04d763a61fcf0200869e3209fa33
02fe7159034b04d763a61fcf0200869e3209fa33

# Jslib: Apply Prettier https://github.com/bitwarden/jslib/pull/581
193434461dbd9c48fe5dcbad95693470aec422ac
# Jslib: Monorepository https://github.com/bitwarden/clients/pull/2824/commits/d7492e3cf320410e74ebd0e0675ab994e64bd01a
d7492e3cf320410e74ebd0e0675ab994e64bd01a
18 changes: 0 additions & 18 deletions .gitmodules

This file was deleted.

4 changes: 1 addition & 3 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
**/dist
**/coverage

**/jslib

# External libraries / auto synced locales
apps/browser/src/_locales
apps/browser/src/scripts/duo.js
Expand All @@ -24,4 +22,4 @@ apps/web/src/404/bootstrap.min.css
apps/web/src/locales

# Github Workflows
.github/workflows
.github/workflows
21 changes: 21 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,24 @@ git merge clients/master
# Push to clients or your own fork
```

### Jslib

```
# Merge master
git merge master
# Merge branch mono-repo
git merge d7492e3cf320410e74ebd0e0675ab994e64bd01a
# Verify files are placed in libs
# Add remote
git remote add clients git@github.com:bitwarden/clients.git
# Merge against clients master
git fetch clients
git merge clients/master
# Push to clients or your own fork
```
1 change: 0 additions & 1 deletion apps/browser/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ module.exports = {
moduleNameMapper: pathsToModuleNameMapper(compilerOptions?.paths || {}, {
prefix: "<rootDir>/",
}),
modulePathIgnorePatterns: ["jslib"],
};
1 change: 0 additions & 1 deletion apps/browser/jslib
Submodule jslib deleted from 1ea282
10 changes: 5 additions & 5 deletions apps/browser/src/popup/scss/popup.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
$icomoon-font-path: "../../../jslib/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../../jslib/angular/src/images/cards/";
$icomoon-font-path: "../../../../../libs/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../../../../libs/angular/src/images/cards/";

@import "../../../jslib/angular/src/scss/webfonts.css";
@import "../../../jslib/angular/src/scss/bwicons/styles/style.scss";
@import "../../../../../libs/angular/src/scss/webfonts.css";
@import "../../../../../libs/angular/src/scss/bwicons/styles/style.scss";
@import "variables.scss";
@import "../../../jslib/angular/src/scss/icons.scss";
@import "../../../../../libs/angular/src/scss/icons.scss";
@import "base.scss";
@import "grid.scss";
@import "box.scss";
Expand Down
4 changes: 2 additions & 2 deletions apps/browser/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"sourceMap": true,
"baseUrl": ".",
"paths": {
"jslib-common/*": ["jslib/common/src/*"],
"jslib-angular/*": ["jslib/angular/src/*"]
"jslib-common/*": ["../../libs/common/src/*"],
"jslib-angular/*": ["../../libs/angular/src/*"]
}
},
"angularCompilerOptions": {
Expand Down
1 change: 0 additions & 1 deletion apps/cli/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ module.exports = {
moduleNameMapper: pathsToModuleNameMapper(compilerOptions?.paths || {}, {
prefix: "<rootDir>/",
}),
modulePathIgnorePatterns: ["jslib"],
};
1 change: 0 additions & 1 deletion apps/cli/jslib
Submodule jslib deleted from 77ca57
4 changes: 2 additions & 2 deletions apps/cli/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"sourceMap": true,
"baseUrl": ".",
"paths": {
"jslib-common/*": ["jslib/common/src/*"],
"jslib-node/*": ["jslib/node/src/*"]
"jslib-common/*": ["../../libs/common/src/*"],
"jslib-node/*": ["../../libs/node/src/*"]
}
},
"include": ["src"]
Expand Down
1 change: 0 additions & 1 deletion apps/desktop/jslib
Submodule jslib deleted from 1ea282
10 changes: 5 additions & 5 deletions apps/desktop/src/scss/styles.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
$icomoon-font-path: "../../jslib/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../jslib/angular/src/images/cards/";
$icomoon-font-path: "../../../../libs/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../../../libs/angular/src/images/cards/";

@import "../../jslib/angular/src/scss/webfonts.css";
@import "../../jslib/angular/src/scss/bwicons/styles/style.scss";
@import "../../../../libs/angular/src/scss/webfonts.css";
@import "../../../../libs/angular/src/scss/bwicons/styles/style.scss";
@import "~@angular/cdk/overlay-prebuilt.css";
@import "variables.scss";
@import "base.scss";
Expand All @@ -19,4 +19,4 @@ $card-icons-base: "../../jslib/angular/src/images/cards/";
@import "header.scss";
@import "left-nav.scss";
@import "loading.scss";
@import "../../jslib/angular/src/scss/icons.scss";
@import "../../../../libs/angular/src/scss/icons.scss";
8 changes: 4 additions & 4 deletions apps/desktop/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
"types": [],
"baseUrl": ".",
"paths": {
"tldjs": ["jslib/common/src/misc/tldjs.noop"],
"jslib-common/*": ["jslib/common/src/*"],
"jslib-angular/*": ["jslib/angular/src/*"],
"jslib-electron/*": ["jslib/electron/src/*"]
"tldjs": ["../../libs/common/src/misc/tldjs.noop"],
"jslib-common/*": ["../../libs/common/src/*"],
"jslib-angular/*": ["../../libs/angular/src/*"],
"jslib-electron/*": ["../../libs/electron/src/*"]
}
},
"angularCompilerOptions": {
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/tsconfig.renderer.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": "./tsconfig.json",
"exclude": ["src/entry.ts", "src/main.ts", "src/main", "src/proxy", "jslib/**/*.main.ts"]
"exclude": ["src/entry.ts", "src/main.ts", "src/main", "src/proxy"]
}
3 changes: 0 additions & 3 deletions apps/desktop/webpack.renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ const common = {
plugins: [],
resolve: {
extensions: [".tsx", ".ts", ".js"],
alias: {
jslib: path.join(__dirname, "jslib/src"),
},
symlinks: false,
modules: [path.resolve("../../node_modules")],
},
Expand Down
1 change: 0 additions & 1 deletion apps/web/jslib
Submodule jslib deleted from f4066b
10 changes: 5 additions & 5 deletions apps/web/src/scss/styles.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
$icomoon-font-path: "../../jslib/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../jslib/angular/src/images/cards/";
$icomoon-font-path: "../../../../libs/angular/src/scss/bwicons/fonts/";
$card-icons-base: "../../../../libs/angular/src/images/cards/";

@import "../../jslib/angular/src/scss/webfonts.css";
@import "../../../../libs/angular/src/scss/webfonts.css";
@import "./variables";
@import "../../jslib/angular/src/scss/bwicons/styles/style.scss";
@import "../../jslib/angular/src/scss/icons.scss";
@import "../../../../libs/angular/src/scss/bwicons/styles/style.scss";
@import "../../../../libs/angular/src/scss/icons.scss";
@import "@angular/cdk/overlay-prebuilt.css";

//@import "~bootstrap/scss/bootstrap";
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/scss/tailwind.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
@tailwind components;
@tailwind utilities;

@import "../../jslib/components/src/tw-theme.css";
@import "../../../../libs/components/src/tw-theme.css";
2 changes: 1 addition & 1 deletion apps/web/tailwind.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-undef, @typescript-eslint/no-var-requires */
const config = require("./jslib/components/tailwind.config.base");
const config = require("../../libs/components/tailwind.config.base");

module.exports = config;
10 changes: 5 additions & 5 deletions apps/web/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"extends": "./jslib/shared/tsconfig",
"extends": "../../libs/shared/tsconfig",
"compilerOptions": {
"baseUrl": ".",
"paths": {
"tldjs": ["jslib/common/src/misc/tldjs.noop"],
"jslib-common/*": ["jslib/common/src/*"],
"jslib-angular/*": ["jslib/angular/src/*"],
"@bitwarden/components": ["jslib/components/src"],
"tldjs": ["../../libs/common/src/misc/tldjs.noop"],
"jslib-common/*": ["../../libs/common/src/*"],
"jslib-angular/*": ["../../libs/angular/src/*"],
"@bitwarden/components": ["../../libs/components/src"],
"src/*": ["src/*"]
}
},
Expand Down
16 changes: 0 additions & 16 deletions libs/.editorconfig

This file was deleted.

4 changes: 0 additions & 4 deletions libs/.eslintignore

This file was deleted.

23 changes: 0 additions & 23 deletions libs/.eslintrc.json

This file was deleted.

1 change: 0 additions & 1 deletion libs/.git-blame-ignore-revs

This file was deleted.

1 change: 0 additions & 1 deletion libs/.gitattributes

This file was deleted.

25 changes: 0 additions & 25 deletions libs/.github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

16 changes: 0 additions & 16 deletions libs/.github/workflows/enforce-labels.yml

This file was deleted.

1 change: 0 additions & 1 deletion libs/.husky/.gitignore

This file was deleted.

4 changes: 0 additions & 4 deletions libs/.husky/pre-commit

This file was deleted.

7 changes: 0 additions & 7 deletions libs/.prettierignore

This file was deleted.

3 changes: 0 additions & 3 deletions libs/.prettierrc.json

This file was deleted.

16 changes: 0 additions & 16 deletions libs/.vscode/launch.json

This file was deleted.

12 changes: 0 additions & 12 deletions libs/.vscode/tasks.json

This file was deleted.

Loading

0 comments on commit 5780bf8

Please sign in to comment.