feat(client): add chat url link to chapters

[Ismailtlem]

• I have read Chapter's contributing guidelines.
• My pull request has a descriptive title (not a vague title like Update README.md).
• My pull request targets the main branch of Chapter.

Related to #104

[gitpod-io]

[ghost]

CodeSee Review Map:

Review in an interactive map

View more CodeSee Maps

Legend

[ojeytonwilliams]

Thanks for putting this together, @Ismailtlem, it's working nicely.

I noticed a few minor issues:

[ojeytonwilliams]

Suggested change

	chatUrl String @default("")
	chatUrl String?

We don't need to specify the default, since it's optional.

[ojeytonwilliams]

Suggested change

	type: 'text',
	type: 'url',

They're all going to be urls, I think.

[ojeytonwilliams]

Could you make this conditional on the chatUrl existing? It looks a little odd to see Chat Link: without the link.

[ojeytonwilliams]

Suggested change

	@Field(() => String)
	chatUrl: string;
	@Field(() => String, { nullable: true })
	chatUrl?: string | null;

This is necessary if we make the field optional. Unfortunately, the fact it can now be null needs to be handled by ChapterForm. For now it's fine to use

defaultValue={defaultValues[key] ?? undefined}

it's ugly, but it'll do until I come up with something nicer.

[ojeytonwilliams]

Suggested change

	@Field(() => String)
	chatUrl: string;
	@Field(() => String, { nullable: true })
	chatUrl?: string | null;

[ojeytonwilliams]

Suggested change

	@Field(() => String)
	chatUrl: string;
	@Field(() => String, { nullable: true })
	chatUrl?: string | null;

[ojeytonwilliams]

Thanks @Ismailtlem it all LGTM, now 👍

[allella]

@all-contributors add @Ismailtlem for code

[allcontributors]

@allella

I've put up a pull request to add @Ismailtlem! 🎉