Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misc enhancements #31454

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jun 27, 2022

Changes

  • Check for merge conflicts in repo before dependency setup in the CI pipeline [better failfast]
  • Use assertSequenceEqual for resilient tests (that are dependent on frappe.db.sql retval)
  • perf: Remove unnecessary query for GlobalDefaults.current_fiscal_year being None

Changes inspired by MariaDB client switch in frappe/frappe#16961

@gavindsouza gavindsouza force-pushed the mariadb-client-refactor branch 8 times, most recently from fcedebb to 0c81f8f Compare July 5, 2022 05:19
@gavindsouza gavindsouza force-pushed the mariadb-client-refactor branch 6 times, most recently from 3746879 to 58b6f31 Compare July 9, 2022 05:25
@gavindsouza gavindsouza force-pushed the mariadb-client-refactor branch 3 times, most recently from b42e9a9 to f1ee7a2 Compare July 21, 2022 08:17
@gavindsouza gavindsouza force-pushed the mariadb-client-refactor branch 3 times, most recently from 6c20fc3 to 51be966 Compare July 25, 2022 06:16
@gavindsouza gavindsouza changed the title ci: Add MariaDB Connector/C Development files fix: Misc enhancements Jul 25, 2022
@gavindsouza gavindsouza marked this pull request as ready for review July 25, 2022 06:29
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #31454 (3c26415) into develop (9439a7f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31454      +/-   ##
===========================================
+ Coverage    63.31%   63.41%   +0.10%     
===========================================
  Files          813      813              
  Lines        57507    57507              
===========================================
+ Hits         36409    36469      +60     
+ Misses       21098    21038      -60     
Impacted Files Coverage Δ
...t/setup/doctype/global_defaults/global_defaults.py 97.43% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 60.90% <0.00%> (-1.37%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 93.75% <0.00%> (-0.97%) ⬇️
... and 28 more

@gavindsouza gavindsouza merged commit 7b90986 into frappe:develop Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant