Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get_fiscal_years API #31337

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jun 13, 2022

Changes

* Optimize fiscal year options generation
* Don't pass unrequired criterions / values to prepared query
* Use QB notation for raw query
@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jun 13, 2022
@gavindsouza gavindsouza requested a review from ankush as a code owner June 13, 2022 07:52
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #31337 (e9af68e) into develop (3a3d136) will increase coverage by 0.02%.
The diff coverage is 92.00%.

@@             Coverage Diff             @@
##           develop   #31337      +/-   ##
===========================================
+ Coverage    63.56%   63.58%   +0.02%     
===========================================
  Files          985      985              
  Lines        67567    67549      -18     
===========================================
+ Hits         42949    42954       +5     
+ Misses       24618    24595      -23     
Impacted Files Coverage Δ
...e/period_closing_voucher/period_closing_voucher.py 88.23% <ø> (ø)
erpnext/regional/report/irs_1099/irs_1099.py 38.02% <50.00%> (ø)
erpnext/accounts/utils.py 70.09% <93.75%> (+0.28%) ⬆️
erpnext/manufacturing/doctype/job_card/job_card.py 71.09% <100.00%> (+0.06%) ⬆️
...t/accounts/report/sales_register/sales_register.py 76.02% <0.00%> (-5.85%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 79.02% <0.00%> (-2.10%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 74.16% <0.00%> (-1.85%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 88.52% <0.00%> (-1.64%) ⬇️
erpnext/portal/utils.py 27.69% <0.00%> (-1.54%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 61.81% <0.00%> (-1.37%) ⬇️
... and 16 more

@ankush ankush merged commit 697fbe9 into frappe:develop Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants