Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(india): E Invoice Cancel Eway Bill is enabled. #30888

Conversation

maharshivpatel
Copy link
Contributor

@maharshivpatel maharshivpatel commented May 3, 2022

Adaequare has enabled E-Way Bill Cancellation on thier API so necessary changes are made to enable functionality for the same.

This closes #30887

no-docs

Adaequare has enabled E-Way Bill Cancellation on thier API so neccesory changes are made to enable functionality for the same.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #30888 (6018b86) into develop (826c3f5) will increase coverage by 0.21%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop   #30888      +/-   ##
===========================================
+ Coverage    62.76%   62.98%   +0.21%     
===========================================
  Files          983      983              
  Lines        67062    67061       -1     
===========================================
+ Hits         42092    42238     +146     
+ Misses       24970    24823     -147     
Impacted Files Coverage Δ
erpnext/utilities/activation.py 62.85% <ø> (+48.57%) ⬆️
erpnext/regional/india/e_invoice/utils.py 42.07% <25.00%> (+0.05%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 80.24% <0.00%> (-1.65%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 65.64% <0.00%> (-0.77%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 79.02% <0.00%> (-0.70%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 76.87% <0.00%> (-0.69%) ⬇️
... and 31 more

i have removed comment to fix linter error.
I have removed set_value as they are unnecessary and will be updated after a successful API request.
nextchamp-saqib
nextchamp-saqib previously approved these changes May 6, 2022
@nextchamp-saqib nextchamp-saqib added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix needs-tests This PR needs automated unit-tests. squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(india): E Invoice Cancel Eway Bill is now available.
2 participants