-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(india): E Invoice Cancel Eway Bill is enabled. #30888
Merged
nextchamp-saqib
merged 7 commits into
frappe:develop
from
maharshivpatel:feat-india-e_invoice-cancel-eway-bill
May 7, 2022
Merged
feat(india): E Invoice Cancel Eway Bill is enabled. #30888
nextchamp-saqib
merged 7 commits into
frappe:develop
from
maharshivpatel:feat-india-e_invoice-cancel-eway-bill
May 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adaequare has enabled E-Way Bill Cancellation on thier API so neccesory changes are made to enable functionality for the same.
maharshivpatel
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
May 3, 2022 09:26
Codecov Report
@@ Coverage Diff @@
## develop #30888 +/- ##
===========================================
+ Coverage 62.76% 62.98% +0.21%
===========================================
Files 983 983
Lines 67062 67061 -1
===========================================
+ Hits 42092 42238 +146
+ Misses 24970 24823 -147
|
i have removed comment to fix linter error.
I have removed set_value as they are unnecessary and will be updated after a successful API request.
nextchamp-saqib
previously approved these changes
May 6, 2022
nextchamp-saqib
force-pushed
the
feat-india-e_invoice-cancel-eway-bill
branch
from
May 6, 2022 09:15
f80cf29
to
1da6e69
Compare
nextchamp-saqib
added
the
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
label
May 6, 2022
nextchamp-saqib
approved these changes
May 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2022
) (cherry picked from commit b8dc40b)
hrwX
pushed a commit
to hrwX/erpnext
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-13-hotfix
needs-tests
This PR needs automated unit-tests.
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaequare has enabled E-Way Bill Cancellation on thier API so necessary changes are made to enable functionality for the same.
This closes #30887
no-docs