Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated print format #29754

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

sagarvora
Copy link
Collaborator

The format GST POS Invoice exists for two DocTypes: Sales Invoice and POS Invoice.

However, while syncing the one for POS Invoice always overwrites the one for Sales Invoice. Hence, removing files for the Sales Invoice format.


When searching for a print format called GST POS Invoice, only the one for POS Invoice is visible:

image


Alternate solution: keep this format with a different name.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 11, 2022
@sagarvora sagarvora removed the needs-tests This PR needs automated unit-tests. label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #29754 (d93d2a8) into develop (77be982) will increase coverage by 6.85%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29754      +/-   ##
===========================================
+ Coverage    52.07%   58.92%   +6.85%     
===========================================
  Files         1111     1112       +1     
  Lines        69408    69547     +139     
===========================================
+ Hits         36146    40984    +4838     
+ Misses       33262    28563    -4699     
Impacted Files Coverage Δ
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-56.63%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 80.19% <0.00%> (-12.88%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 97.67% <0.00%> (-2.33%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-2.28%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 86.77% <0.00%> (-1.95%) ⬇️
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.16% <0.00%> (-1.64%) ⬇️
... and 194 more

@nextchamp-saqib nextchamp-saqib merged commit 80944e6 into frappe:develop Feb 12, 2022
nextchamp-saqib added a commit that referenced this pull request Feb 12, 2022
…-29754

chore: remove deprecated print format (backport #29754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants