Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add link to leave application in leave notification #29316

Merged
merged 1 commit into from
Jan 17, 2022
Merged

feat: add link to leave application in leave notification #29316

merged 1 commit into from
Jan 17, 2022

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jan 17, 2022 •
edited
Loading

Add a link to open leave application in the leave notification template

image

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 17, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jan 17, 2022
@ruchamahabal ruchamahabal added this to the v14.0 milestone Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #29316 (bafe41f) into develop (66bf21f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29316      +/-   ##
===========================================
+ Coverage    57.96%   57.98%   +0.02%     
===========================================
  Files         1110     1110              
  Lines        68089    68080       -9     
===========================================
+ Hits         39465    39474       +9     
+ Misses       28624    28606      -18
Impacted Files Coverage Δ
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-2.32%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 91.37% <0.00%> (-1.73%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 86.84% <0.00%> (-1.32%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
... and 17 more

@ruchamahabal ruchamahabal merged commit b07c1f3 into frappe:develop Jan 17, 2022
@ruchamahabal ruchamahabal deleted the leave-notification branch January 17, 2022 09:07
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-14-beta-pre-release

mergify bot pushed a commit that referenced this pull request Jan 29, 2022
@ruchamahabal
feat: add link to leave application in leave notification (#29316)
b8d1436 
(cherry picked from commit b07c1f3)

# Conflicts:
#	erpnext/patches.txt
@mergify mergify bot mentioned this pull request Jan 29, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-14-beta-pre-release

✅ Backports have been created

ruchamahabal added a commit that referenced this pull request Jan 29, 2022
@mergify @ruchamahabal
feat: add link to leave application in leave notification (backport #…
d718dab 
…29316) (#29512)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HR
Projects
None yet
Milestone
v14.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ruchamahabal