-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove unnecessary creation of companies #28965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28965 +/- ##
===========================================
- Coverage 55.59% 55.58% -0.01%
===========================================
Files 1128 1128
Lines 67285 67287 +2
===========================================
- Hits 37404 37400 -4
- Misses 29881 29887 +6
|
ankush
added
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
labels
Dec 20, 2021
ankush
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
December 20, 2021 16:24
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2021
test: remove unnecessary creation of companies (cherry picked from commit d7148ad)
ankush
added a commit
that referenced
this pull request
Dec 20, 2021
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
test: remove unnecessary creation of companies
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
test: remove unnecessary creation of companies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests end up creating 19-20 companies... some for really bad uses 🤦
For instance in one test, to check abbreviations are correctly concatenated a whole new company is getting created 🥲
Results: this test run is actually slower (LOL) due to randomness. But you can kinda expect 30-40 seconds saving per run.