Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Regional): KSA E-Invoing optimizations and POS support #28776

Merged
merged 23 commits into from
Dec 8, 2021

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Dec 7, 2021

Objectives:

  • Rename QR Code field to match localization
  • Add QR Code to POS Invoice
  • Print Format for POS Invoice with QR Code
  • In case of missing QR Code field while submitting invoice, create the field and then QR Code
  • Disable KSA print formats for other countries

#no-docs

@rtdany10 rtdany10 changed the title feat: KSA E-Invoing optimizations and POS support feat(Regional): KSA E-Invoing optimizations and POS support Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #28776 (4a31655) into develop (9a644f6) will increase coverage by 8.41%.
The diff coverage is 6.15%.

@@             Coverage Diff             @@
##           develop   #28776      +/-   ##
===========================================
+ Coverage    46.80%   55.22%   +8.41%     
===========================================
  Files         1122     1122              
  Lines        66777    66784       +7     
===========================================
+ Hits         31255    36879    +5624     
+ Misses       35522    29905    -5617     
Impacted Files Coverage Δ
erpnext/hooks.py 0.00% <ø> (ø)
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
erpnext/regional/saudi_arabia/utils.py 25.31% <7.14%> (+1.56%) ⬆️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 71.02% <0.00%> (+0.23%) ⬆️
... and 190 more

@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 7, 2021

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 7, 2021

Linters failing with error: The PR contains a SQL query that may be re-written with frappe.qb
Since we need to backport, I believe that can be ignored for the time being and be fixed in a future pull request.

@deepeshgarg007 deepeshgarg007 self-assigned this Dec 7, 2021
erpnext/regional/saudi_arabia/setup.py Outdated Show resolved Hide resolved
erpnext/regional/saudi_arabia/utils.py Outdated Show resolved Hide resolved
@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 8, 2021

Unrelated test failure?

@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 8, 2021

@deepeshgarg007 tests all passing. Can we merge this PR?

@deepeshgarg007 deepeshgarg007 merged commit 121f8ae into frappe:develop Dec 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2021

backport version-13-hotfix

❌ No backport have been created

  • Backport to branch version-13-hotfix failed
    Pull request with merge commit are not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants