chore: Clean up imports #27302
Merged
chore: Clean up imports #27302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChillarAnand
force-pushed
the
imports
branch
2 times, most recently
from
78f6e7c
to
343f6a5
Compare
ChillarAnand
force-pushed
the
imports
branch
6 times, most recently
from
4d01b05
to
ff3125e
Compare
ChillarAnand
force-pushed
the
imports
branch
from
ff3125e
to
2788868
Compare
ChillarAnand
force-pushed
the
imports
branch
from
2788868
to
d05000d
Compare
ChillarAnand
force-pushed
the
imports
branch
from
e7a824d
to
54999fb
Compare
ChillarAnand
force-pushed
the
imports
branch
3 times, most recently
from
84f3dcd
to
4e5e8b7
Compare
ChillarAnand
force-pushed
the
imports
branch
from
9a76573
to
1b7d29b
Compare
|
@gavindsouza @surajshetty3416 we are going ahead with sorted imports using isort. The config that will be used is compatible with This will likely mess up the history for import lines but I guess it's a reasonable compromise. We can add the final commit in Config file: https://github.com/frappe/erpnext/blob/fe53fdb750a5d70e9e3698ec18b11dd8e88968e3/pyproject.toml |
ChillarAnand
requested review from
deepeshgarg007,
marination,
nextchamp-saqib,
pateljannat,
rohitwaghchaure and
ruchamahabal
as code owners
ankush
added
squash
ankush
approved these changes
Sep 2, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* chore: Added isort to pre-commit config * chore: Sort imports with isort * chore: Clean up imports with pycln * chore: Sort imports with isort * chore: Fix import issues * chore: Clean up sider issues * chore: Remove import errors from flake8 ignore list * chore: Clean up lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used isort/pycln to clean up the imports & added import checks to CI.