parameratized contracts, arguments, and networking #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've made a few changes, outlined in the changelog and readme:
4.3.2
srcfolder, as thefindcommand incommon.shnow looks only in thesrcfolder. This is to improve on naming conflicts with imported packages.helper-config.shfor parameratizing arguments for different contracts based on the network you're on.deploy.shto be parameratized for contracts and arguments. Adding aCONTRACT=<contractname>in the command line will switch the contract. Additionally, if you want arguments of that contract to be added correctly, you have to add them tohelper-config.sh.I found these tweaks a lot easier to make bigger projects with dependencies. Let me know if you like! I'm a bit of a Makefile noob, so if I did some stuff that wasn't best practice, let me know!