Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added abstract keyword to GreeterTest #28

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Added abstract keyword to GreeterTest #28

merged 1 commit into from
Oct 7, 2021

Conversation

jimmyx0x
Copy link
Contributor

@jimmyx0x jimmyx0x commented Oct 7, 2021

GreeterTest is never actually instantiated, it's only being inherited by the contracts in the .t.sol files. As such we can mark the contract as abstract

@gakonst gakonst merged commit d8739c8 into foundry-rs:master Oct 7, 2021
@gakonst
Copy link
Member

gakonst commented Oct 7, 2021

good call - thank you.

@gakonst gakonst mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyx0x @gakonst