Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

CLI help cleanup #945

Merged
merged 3 commits into from
Feb 20, 2018
Merged

CLI help cleanup #945

merged 3 commits into from
Feb 20, 2018

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Feb 15, 2018

This PR cleans up the CLI help text to use the new namespace:kind/name format. It also uppercases release help descriptions for consistency. Additionally, it fixes the type of the ReleaseKindExecute constant.

@rndstr rndstr requested a review from samb1729 February 15, 2018 21:54
@@ -31,7 +31,7 @@ func (opts *controllerShowOpts) Command() *cobra.Command {
cmd := &cobra.Command{
Use: "list-images",
Short: "Show the deployed and available images for a controller.",
Example: makeExample("fluxctl list-images --namespace default --controller=deployment/foo"),
Example: makeExample("fluxctl list-images --namespace default --controller=default:deployment/foo"),

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Roli!

@rndstr rndstr merged commit 4faa034 into master Feb 20, 2018
@rndstr rndstr deleted the cli-help-cleanup branch February 20, 2018 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants