Implement versioned fluxd protocol #491

awh · 2017-03-15T11:48:02Z

WIP scaffolding for versioning the fluxd protocol. TBD:

'NeedsUpgrade' error to be returned to platform clients (e.g. fluxsvc on behalf of fluxctl) when an old fluxd can't support the requested operation
Sensible fluxd behaviour when it tries to talk to a deprecated RegisterDaemon endpoint

squaremo

Just a suggestion that came to mind.

Another thought: can we move the versioned bits into packages, platform/v4 etc.? Or too much faff.

platform/rpc/clientV4.go

@@ -10,35 +10,35 @@ import (
 	"github.com/weaveworks/flux/platform"


squaremo

LGTM, nice work Adam

squaremo · 2017-03-16T14:56:48Z

'NeedsUpgrade' error to be returned to platform clients (e.g. fluxsvc on behalf of fluxctl) when an old fluxd can't support the requested operation

Done neatly.

Sensible fluxd behaviour when it tries to talk to a deprecated RegisterDaemon endpoint

Not a problem we'll have until we actually deprecate an endpoint, but we should build it in at least a version before we do that :)

awh added 2 commits March 14, 2017 17:27

Platform versioning experiment

b57356f

Address review comments

f7df8f1

squaremo reviewed Mar 15, 2017

View reviewed changes

platform/rpc/clientV4.go

@@ -10,35 +10,35 @@ import (

"github.com/weaveworks/flux/platform"

This comment was marked as abuse.

Sign in to view

awh added 2 commits March 15, 2017 14:49

Implement UpgradeNeededError

bb2115c

Fix unit tests

3d68d45

squaremo approved these changes Mar 16, 2017

View reviewed changes

squaremo changed the title ~~[WIP] Implement versioned fluxd protocol~~ Implement versioned fluxd protocol Mar 16, 2017

squaremo merged commit f8cd394 into master Mar 16, 2017

awh deleted the versioned-fluxd-protocol branch May 8, 2017 08:38

Provide feedback

		@@ -10,35 +10,35 @@ import (
		"github.com/weaveworks/flux/platform"