This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add JSON output option for fluxctl's list-images and list-workloads #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevrosen
changed the title
hiddeco
reviewed
Feb 10, 2020
trevrosen
force-pushed
the
json-output
branch
2 times, most recently
from
06d8cfe
to
5036864
Compare
hiddeco
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A JSON output option for
fluxctl list-workloadsandfluxctl list-imagesWhy
Building tooling (such as chatbot functionality) is much easier with a machine-readable output.
Note
I added Testify to the test build b/c I think that the single-line assertions make test code really easy to read. If this is controversial, I can remove. It tends to be the single thing that I use outside of stdlib for tests.