This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make Kubernetes resources exclusion configurable #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
changed the title
hiddeco
reviewed
Jan 15, 2020
stefanprodan
force-pushed
the
exclude-webhook
branch
from
c365852
to
ba2e912
Compare
stefanprodan
changed the title
2opremio
reviewed
Jan 15, 2020
2opremio
approved these changes
Jan 15, 2020
stefanprodan
force-pushed
the
exclude-webhook
branch
from
ba2e912
to
05a8351
Compare
|
@2opremio please take a look again, the filtering happens at group level first (to avoid API calls errors when fetching the resources) and a 2nd time for the Kind matching. Also if you have a better description for the flag please write it here. PS. I've also excluded the Event kind as the events could fill Flux memory. |
stefanprodan
force-pushed
the
exclude-webhook
branch
from
05a8351
to
09dfe4e
Compare
Ah, sorry, I had missed that (I was checking the PR on the phone) |
|
How about |
2opremio
reviewed
Jan 15, 2020
stefanprodan
force-pushed
the
exclude-webhook
branch
from
09dfe4e
to
827b2bd
Compare
stefanprodan
force-pushed
the
exclude-webhook
branch
from
827b2bd
to
c405035
Compare
2opremio
reviewed
Jan 16, 2020
2opremio
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--k8s-exclude-resourceto fluxd command args to make the Kubernetes resources exclusion configurable.By default the
*metrics.k8s.io/*,webhook.certmanager.k8s.io/*andv1/Eventresources are excluded.Also objects with owner references are excluded from Flux discovery to avoid conflicts between Flux GC and Kubernetes GC.
Fix: #2554
Fix: #2642