This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Refactor e2e script linting #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
fix-e2e-linting
branch
from
48949ec
to
744134c
Compare
hiddeco
approved these changes
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format-checking for
test/e2e/lib/*wasn't working.The reason was that
shfmt -ldoesn't return a non-0 exit code when finding non-compliant files (unlike what I thought). So, I fixed that by using diffing instead of listing.On the way I refactored the whole
lint-e2erecipe.