Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

chart: add the ability to disable the memcached deployment #2393

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

antonosmond
Copy link
Contributor

In some cases it can be useful to deploy flux without memcached e.g. when not using the image scanning features or if you want to use an external memcached service deployed separately from the flux chart.
This change adds the ability to disable the memcached deployment in the helm chart and / or override the memcached hostname.

@stefanprodan
Copy link
Member

@antonosmond have you tested Flux without memcached? If I remember right, it will not sync with git without it.

1 similar comment
@stefanprodan
Copy link
Member

@antonosmond have you tested Flux without memcached? If I remember right, it will not sync with git without it.

@antonosmond
Copy link
Contributor Author

@stefanprodan The change is more about using an external memcached.
In our use case, we have various "domains" each with multiple applications.
Each of those domains runs in its own namespace and we deploy a flux per domain/namespace.
This means we have like 10 flux deployments and we don't want a memcached deployment for each flux. A single instance of memcached should be sufficient.

chart/flux/README.md Outdated Show resolved Hide resolved
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please squash the commits and rebase from master.
Thanks!

@stefanprodan stefanprodan changed the title If applied, this commit will add the ability to disable the memcached deployment chart: add the ability to disable the memcached deployment Aug 22, 2019
@hiddeco hiddeco force-pushed the master branch 2 times, most recently from b3cc044 to 1994d05 Compare August 22, 2019 17:00
And update README.md to be clear that disabling memcached in the
chart requires an external memcached service.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants