Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

[snapcraft] stop using soon-to-be deprecated version-script #2350

Merged
merged 2 commits into from
Aug 13, 2019
Merged

[snapcraft] stop using soon-to-be deprecated version-script #2350

merged 2 commits into from
Aug 13, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach self-assigned this Aug 12, 2019
@dholbach
Copy link
Member Author

I'm sure there's a more elegant way to go about https://github.com/fluxcd/flux/pull/2350/files#diff-5fde7a6d86053f0e1d88c0a2a238941fR26-R28 - but it did the trick (don't want to exit during the build, but catch the return code).

stefanprodan
stefanprodan approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dholbach dholbach merged commit 9372621 into master Aug 13, 2019
@dholbach dholbach deleted the flux-version-script branch August 13, 2019 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees

@dholbach dholbach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholbach @stefanprodan