This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Define custom Helm repositories in the Helm chart #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
We could add the username and password as optional fields too, other than that it looks ok to me.
Thanks @srueg
|
@stefanprodan The BGB (Big Green Button) is yours |
stefanprodan
reviewed
Apr 3, 2019
This simplifies using custom Helm repositories and generates a `repositories.yaml` for the Helm operator. Relates to #1862 Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies using custom Helm repositories and generates a
repositories.yamlfor the Helm operator.Relates to #1862
Signed-off-by: Simon Rüegg simon.ruegg@vshn.ch