Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dwds (and other packages) #86832

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Update dwds (and other packages) #86832

merged 3 commits into from
Jul 22, 2021

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jul 22, 2021 •
edited
Loading

Upgrade all packages, in particular, dwds that contains fixes for test flakes.

Test: enabled previously failing tests.

Closes: #85043
Closes: #85575

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

Anna Gringauze added 2 commits July 21, 2021 17:33
Upgrade all packages
020b9c6 
In particular, bring in dwds with latest fixes for flakes.

Closes: flutter#85043
Related: flutter#85575
Re-enable fixed tests
763f4d4
@flutter-dashboard flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 22, 2021
@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@annagrin
Copy link
Contributor Author

/cc @jonahwilliams I have fixed a couple of issues in the latest dwds (hot restart hangs, broken http connections), let's see if the web_tool_tests are fixed by them.

jonahwilliams
jonahwilliams approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annagrin annagrin mentioned this pull request Jul 22, 2021
Closed
@annagrin annagrin merged commit 84c3b56 into flutter:master Jul 22, 2021
@annagrin annagrin deleted the annagrin/update_dwds branch July 22, 2021 04:47
@annagrin annagrin mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
2 participants
@annagrin @jonahwilliams