Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skwasm Renderer - initial implementation #39072

Merged
merged 51 commits into from
Mar 2, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
f2be860
Started porting prototype over.
eyebrowsoffire Sep 27, 2022
b5a42f4
A few fixes.
eyebrowsoffire Sep 28, 2022
313a055
Converted wasm pragmas to FfiNative annotations.
eyebrowsoffire Sep 29, 2022
5c953e6
Implement a few methods of the renderer.
eyebrowsoffire Sep 29, 2022
1badfec
Some little lint errors.
eyebrowsoffire Nov 3, 2022
7cb9a08
A bit of wiring up of the test harness.
eyebrowsoffire Nov 4, 2022
73ee925
Fix some formatting issues.
eyebrowsoffire Nov 4, 2022
cb65c7b
Minor changes to skwasm renderer.
eyebrowsoffire Nov 8, 2022
1b6f39b
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Dec 6, 2022
f3192dd
A few fixes to get things compiling via dart2wasm.
eyebrowsoffire Dec 9, 2022
dbe87a1
Use `futureToPromise`.
eyebrowsoffire Dec 9, 2022
8397290
Some more fixes for dart2wasm.
eyebrowsoffire Dec 12, 2022
69c4c86
Allow promises to have nullable objects.
eyebrowsoffire Dec 12, 2022
7d61204
Merge branch 'main' into wasm_fixes
eyebrowsoffire Dec 12, 2022
ea59128
Merge branch 'wasm_fixes' into skwasm_renderer
eyebrowsoffire Dec 12, 2022
831be2e
Some changes to skwasm.
eyebrowsoffire Dec 13, 2022
ace664b
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Dec 14, 2022
5db2a4a
Fix up some signatures.
eyebrowsoffire Dec 14, 2022
bfbb993
More expressive warnings.
eyebrowsoffire Dec 14, 2022
adef70b
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Jan 23, 2023
1927e0c
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Jan 23, 2023
8fc257c
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Jan 25, 2023
6e4ddd1
Switch @FfiNative to @Native.
eyebrowsoffire Jan 25, 2023
0461799
Unit tests partially working.
eyebrowsoffire Jan 27, 2023
f45f7ff
License headers.
eyebrowsoffire Jan 28, 2023
7a80ffe
Implemented path metrics.
eyebrowsoffire Jan 28, 2023
38ef597
Only run general UI tests on skwasm if we're in wasm mode.
eyebrowsoffire Jan 28, 2023
8b589a8
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Jan 28, 2023
156f9bc
Update license goldens.
eyebrowsoffire Jan 28, 2023
406fb8b
Converted picture test to a generic ui test.
eyebrowsoffire Jan 28, 2023
91de627
Converted canvas_test.dart to a ui test.
eyebrowsoffire Jan 29, 2023
d787922
Port path_metrics_test.dart to ui.
eyebrowsoffire Jan 29, 2023
9304cb1
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Jan 29, 2023
4eaa927
Coop/Coep headers.
eyebrowsoffire Jan 30, 2023
604627a
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 1, 2023
704d299
Make `felt build` take ninja targets as arguments.
eyebrowsoffire Feb 1, 2023
7ff5d86
Formatting stuff.
eyebrowsoffire Feb 1, 2023
54bad71
Remove --skwasm flag from felt test.
eyebrowsoffire Feb 9, 2023
21f4f5d
Only include COOP/COEP headers when compiling to wasm with skwasm ren…
eyebrowsoffire Feb 9, 2023
7732340
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 10, 2023
a490f9a
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 17, 2023
4561035
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 17, 2023
7fcbc8e
Update sdk_rewriter_test.
eyebrowsoffire Feb 17, 2023
864080f
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 25, 2023
f58b5bc
Update lib/web_ui/dev/test_dart2wasm.js
eyebrowsoffire Feb 27, 2023
6cfe644
Fixed some skwasm build rules.
eyebrowsoffire Feb 27, 2023
885bef4
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 27, 2023
ec5b08e
Whoops, we reversed the isSkwasm logic. Fixed.
eyebrowsoffire Feb 27, 2023
fd91011
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Feb 28, 2023
68110f9
Merge branch 'main' into skwasm_renderer
eyebrowsoffire Mar 1, 2023
9b43948
Address Harry's comments and change the archive structure.
eyebrowsoffire Mar 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up some signatures.
  • Loading branch information
eyebrowsoffire committed Dec 14, 2022
commit 5db2a4aa90bc053186cee0ad09cd624407a1a533
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/skwasm/skwasm_impl/paint.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ class SkwasmPaint implements ui.Paint {
}

@override
ui.PaintingStyle get style => ui.PaintingStyle.values[paintGetPaintStyle(_handle)];
ui.PaintingStyle get style => ui.PaintingStyle.values[paintGetStyle(_handle)];

@override
set style(ui.PaintingStyle style) => paintSetPaintStyle(_handle, style.index);
set style(ui.PaintingStyle style) => paintSetStyle(_handle, style.index);

@override
double get strokeWidth => paintGetStrokeWidth(_handle);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ external void paintDestroy(PaintHandle paint);
@FfiNative<Void Function(PaintHandle, Int)>('skwasm.paint_setBlendMode', isLeaf: true)
external void paintSetBlendMode(PaintHandle paint, int blendMode);

@FfiNative<Void Function(PaintHandle, Int)>('skwasm.paint_setPaintStyle', isLeaf: true)
external void paintSetPaintStyle(PaintHandle paint, int paintStyle);
@FfiNative<Void Function(PaintHandle, Int)>('skwasm.paint_setStyle', isLeaf: true)
external void paintSetStyle(PaintHandle paint, int paintStyle);

@FfiNative<Int Function(PaintHandle)>('skwasm.paint_getPaintStyle', isLeaf: true)
external int paintGetPaintStyle(PaintHandle paint);
@FfiNative<Int Function(PaintHandle)>('skwasm.paint_getStyle', isLeaf: true)
external int paintGetStyle(PaintHandle paint);

@FfiNative<Void Function(PaintHandle, Float)>('skwasm.paint_setStrokeWidth', isLeaf: true)
external void paintSetStrokeWidth(PaintHandle paint, double strokeWidth);
Expand Down
2 changes: 1 addition & 1 deletion lib/web_ui/skwasm/picture.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SKWASM_EXPORT SkPictureRecorder* pictureRecorder_create() {
return new SkPictureRecorder();
}

SKWASM_EXPORT void pictureRecorder_destroy(SkPictureRecorder* recorder) {
SKWASM_EXPORT void pictureRecorder_dispose(SkPictureRecorder* recorder) {
delete recorder;
}

Expand Down