Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Build Web SDK in wasm build tree (#36520)" #36805

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Revert "Build Web SDK in wasm build tree (#36520)" #36805

merged 1 commit into from
Oct 17, 2022

Conversation

eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Oct 17, 2022 •
edited
Loading

Reverts #36520

@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

This pull request cannot be merged due to conflicts. Please resolve conflicts and re-add the revert label.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit auto-submit bot merged commit cafafa1 into flutter:main Oct 17, 2022
@auto-submit auto-submit bot mentioned this pull request Oct 17, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
cafafa141 Revert "Build Web SDK in wasm build tree (flutter#36520)" (f…
98feb4f 
…lutter/engine#36805)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
cafafa141 Revert "Build Web SDK in wasm build tree (flutter#36520)" (f…
6e1369e 
…lutter/engine#36805)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
cafafa141 Revert "Build Web SDK in wasm build tree (flutter#36520)" (f…
a410d38 
…lutter/engine#36805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees
No one assigned
Labels
needs tests platform-web Code specifically for the web engine revert Label used to revert changes in a closed and merged pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyebrowsoffire @yjbanov @fluttergithubbot