Fix annotation manager crashes #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
temporarily deployed
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Inactive
felix-ht
temporarily deployed
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Inactive
AAverin
approved these changes
Apr 14, 2023
felix-mittermeier
pushed a commit
to Ocell-io/flutter-mapbox-gl
that referenced
this pull request
Apr 20, 2023
* fixed crash caused be race condition in layer deletion * better layer ids for annotations * added overlap button to example
sandrews-inc
pushed a commit
to Get-Phil/flutter-mapbox-gl
that referenced
this pull request
May 15, 2023
* fixed crash caused be race condition in layer deletion * better layer ids for annotations * added overlap button to example
FreeGrow
added a commit
to FreeGrow/maps
that referenced
this pull request
Sep 21, 2023
This reverts commit 61b435e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that could happen if multiple overlap placement settings were changed without awaiting the results.
At its core the issue is caused by the fact that two async calls are needed to remove and than add layers.
I fixed this by making addLayer upsert the layer if required.
fixes #1207