Create a static map snapshot #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hungtrn75 im quite busy right now - will take some time until i can review this |
|
hoping to get this feature merge. |
AAverin
reviewed
Aug 21, 2022
AAverin
reviewed
Aug 21, 2022
AAverin
reviewed
Aug 21, 2022
AAverin
approved these changes
Aug 21, 2022
AAverin
reviewed
Aug 22, 2022
|
Looks good to me. |
felix-ht
requested changes
Aug 22, 2022
| case "snapshot#takeSnap": | ||
| { | ||
| FileSource.getInstance(context).activate(); | ||
| MapSnapshotter.Options snapShotOptions = new MapSnapshotter.Options((int) call.argument("width"), (int) call.argument("height")); |
There was a problem hiding this comment.
yes. this is final
mapbox_gl_platform_interface/lib/src/mapbox_gl_platform_interface.dart
Outdated
Show resolved
Hide resolved
felix-ht
reviewed
Aug 23, 2022
felix-ht
approved these changes
Sep 28, 2022
PhilippMatthes
added a commit
to priobike/priobike-flutter-mapbox
that referenced
this pull request
Sep 29, 2022
* Add makefile for formatting (flutter-mapbox-gl#1181) * refactor and fix ci the file * add makefile for formatting and installing formatting tools * Create a static map snapshot (flutter-mapbox-gl#1076) * android impl * take snapshot ios * config for each platform interface * take snapshot in ios * take snap in android && example * android hybrid composition * ios test * test with android hybrid composition * Update README.md * use JPG instead of PNG with writeToDisk option & remove unused funtions * render example result with base64 option * remove team ID in example * iOS: use JPG instead of PNG * rename funtion * test flutter ci * test ci * ci: check swift formatting * ci: test check java formatting * ci: check java formatting * ci: test check java formatting * document for take snapshot feature * revert ci config * migration: jpeg with base64 option * docs: web support * feat: web support with base64 option * ci: test github ci * lint: ignore unnecessary_import * ci: reverse config Co-authored-by: Felix Horvat <felix.horvat@ocell.io> Co-authored-by: Hung Tran <32390731+hungtrn75@users.noreply.github.com>
FreeGrow
added a commit
to FreeGrow/maps
that referenced
this pull request
Sep 21, 2023
This reverts commit 3e490a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #957