Improved map resizing #1061
Merged
Improved map resizing #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
reviewed
May 30, 2022
felix-ht
requested changes
May 30, 2022
FreeGrow
added a commit
to FreeGrow/maps
that referenced
this pull request
Sep 21, 2023
This reverts commit b1479f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change it sometimes happened that the map did not fill the whole parent on web when it was resized, like in the following example:
After these changes it works much more reliable when the browser window gets resized:
after.mov
Besides that it also improves the performance a bit because previously the
_map.resize();function was called every time the map style has loaded whereas now the internal_onMapResize();is called which first checks if the map has to be resized or not and only does it if is required.