Include bli_config.h before bli_system.h in cblas.h.
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - Previously, in cblas.h, bli_config.h was being #included *after* bli_system.h, which meant that the BLIS_ENABLE_SYSTEM macro was never defined in time for proper OS detection. This bug only affected cblas.h -- blis.h had been correctly #including bli_config.h before bli_system.h since fb93d24. Thanks to Edward Smyth for reporting this bug and suggesting the fix.
fgvanzee
added a commit
that referenced
this pull request
Dec 12, 2023
Details: - Previously, in cblas.h, bli_config.h was being #included *after* bli_system.h, which meant that the BLIS_ENABLE_SYSTEM macro was never defined in time for proper OS detection. This bug only affected cblas.h -- blis.h had been correctly #including bli_config.h before bli_system.h since fb93d24. Thanks to Edward Smyth for reporting this bug and suggesting the fix. - (cherry picked from commit a72e456)
|
Oh, I somehow missed to grep for all |
fgvanzee
added a commit
that referenced
this pull request
May 26, 2024
`BLIS_OBJECT_INITIALIZER`. - (cherry picked from a316d2c) Update BLIS_*_INITIALIZER macros for C++ compatibility. (#802) Details: - Remove designated initializer syntax. This isn't officially supported until C++20. - Arrange initializers in the order in which they are defined in the struct. Even with standard or extension support for designated initializers, initializing non-static members out-of-order is an error in C++. - Remove the conditional code which uses '-1' as the default value of the 'pack_buf' member of 'mem_t' in C, but 'BLIS_BUFFER_FOR_GEN_USE' in C++. Simply use the latter as a common-sense default. - (cherry picked from 664cc6b) Add cpu part codes for various manufacturers and use in the code (#794) * Add cpu_id symbols for arm v8. * Add symbols for arm v7. * Always assume firestorm on Apple aarch64. * Fixes incorrect usage of model vs. part in some places. * Fixes #793 - (cherry picked from 1a8c818) Fix errors and typos in docs/BLIS*API.md (#791) Details: - Fixed errors and unified formatting in docs/BLIS*API.md docs. - (cherry picked from c382d8b) Include bli_config.h before bli_system.h in cblas.h. (#789) Details: - Previously, in cblas.h, bli_config.h was being #included *after* bli_system.h, which meant that the BLIS_ENABLE_SYSTEM macro was never defined in time for proper OS detection. This bug only affected cblas.h -- blis.h had been correctly #including bli_config.h before bli_system.h since fb93d24. Thanks to Edward Smyth for reporting this bug and suggesting the fix. - (cherry picked from a72e456) Install helper headers to INCDIR prefix. (#787) Details: - Install one-line headers to INCDIR whose entire purpose is to #include the actual headers within the local 'blis' header directory so that applications can #include "blis.h" instead of #include <blis/blis.h> (and/or "cblas.h" instead of <blis/cblas.h> if CBLAS is enabled) when headers are installed to global paths. (Note that INCDIR is the installation prefix for headers as specified by '--includedir=INCDIR', which defaults to 'PREFIX/include' if not specified.) Not sure how this problem went unreported for so long, since presumably any user trying to #include "blis.h" from a global installation would have encountered a compiler error. - The one-line blis.h and cblas.h headers now reside in the 'build' directory, ready to install as is. - Thanks to to Jed Brown for reporting this via Issue #786, and for Devin Matthews and Mo Zhou for their engagement. - Harmonized the rule in the top-level Makefile for installing blis.pc into SHAREDIR/pkgconfig with conventions for others vis-a-vis verbosity/non-verbosity. - (cherry picked from 141a6c9) Allow users to defines [sd]complex using std::complex (#784) Details: - In C++ applications, it makes a lot of sense to interface to BLIS using C++'s standard complex number library, which uses a template class std::complex. Obviously BLIS doesn't know anything about this and defaults to a custom struct to represent complex numbers. This PR updates the bli_[cz]{real,imag}() functions to accept std::complex numbers when a C++ compiler is being used. Note that this has no effect on the compilation of the BLIS library (or testsuite), and only comes into play when including blis.h into a C++ project and forcing the use of std::complex for scomplex and dcomplex. - The application can explicitly request std:complex-based types via: #define BLIS_ENABLE_STD_COMPLEX #include <blis.h> // Call BLIS functions using std::complex<double> here. - Fixed a bug in the definition of some scalar level-0 macros, since bli_creal()/bli_cimag() and bli_zreal()/bli_zimag() are no longer interchangeable. - (cherry picked from 2d94392) CREDITS file update. - (cherry picked from f7ce54a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
cblas.h,bli_config.hwas being#includedafterbli_system.h, which meant that theBLIS_ENABLE_SYSTEMmacro was never defined in time for proper OS detection. This bug only affectedcblas.h--blis.hhad been correctly includingbli_config.hbeforebli_system.hsince fb93d24. Thanks to Edward Smyth for reporting this bug and suggesting the fix.cc: @edwsmyth