Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export functions without def file #303

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Export functions without def file #303

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11b0523
Revert "restore bli_extern_defs exporting for now"
isuruf Feb 27, 2019
7c6df52
Remove symbols not intended to be public
isuruf Feb 27, 2019
509df8f
No need of def file anymore
isuruf Feb 27, 2019
358d447
Fix whitespace
isuruf Feb 27, 2019
c6f9f37
No need of configure option
isuruf Feb 27, 2019
7d17c8a
Remove export macro from definitions
isuruf Mar 9, 2019
892e531
Remove blas export macro from definitions
isuruf Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No need of def file anymore
  • Loading branch information
@isuruf
isuruf committed Feb 27, 2019
commit 509df8facd433c11e84f7ec98da859ade35c3afb
4 changes: 2 additions & 2 deletions common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,9 @@ SOFLAGS := -shared
ifeq ($(IS_WIN),yes)
# Windows shared library link flags.
ifeq ($(CC_VENDOR),clang)
SOFLAGS += -Wl,-def:build/libblis-symbols.def -Wl,-implib:$(BASE_LIB_PATH)/$(LIBBLIS).lib
SOFLAGS += -Wl,-implib:$(BASE_LIB_PATH)/$(LIBBLIS).lib
else
SOFLAGS += -Wl,--export-all-symbols -Wl,--out-implib,$(BASE_LIB_PATH)/$(LIBBLIS).dll.a
SOFLAGS += -Wl,--out-implib,$(BASE_LIB_PATH)/$(LIBBLIS).dll.a
endif
else
# Linux shared library link flags.
Expand Down